RE: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

Zhang, Xiantao
2009-04-29T14:03:23Z

Jes Sorensen wrote:
> Zhang, Xiantao wrote:
>> Jes Sorensen wrote:
>>> What do you think of this one?
>>
>> Hi, Jes
>> Except nvram stuff, I don't see the difference with my patch.
>> Could you provide an incremental patch to fix nvram stuff ? :)
>> Xiantao
>
> Hi Xiantao,
>
> The main difference is that my patch cleans up the interfaces and
> calls to the various functions, and removes a bunch of global
> variables as well.

I still can't see the difference with the patch in Avi's tree except nvram stuff. And I believe the global variable you mentioned should be only used for nvram. So I propose an incremental patch for that. :)

> The problem with the NVRAM stuff is that I don't know how it is
> supposed to work. Do you have any specification or documentation for
> it?
No specification, and we just followed the guest's firmware logic for that. The link for guest firmware: http://xenbits.xensource.com/ext/efi-vfirmware.hg