RE: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c

Zhang, Xiantao
2009-04-29T08:36:22Z

Jes Sorensen wrote:
> Zhang, Xiantao wrote:
>> Avi Kivity wrote:
>>> I haven't pushed this out yet, so I can apply a replacement patch.
>>
>> We don't need flush_icache_range here, because I believe it is
>> called in cpu_physical_memory_write. Xiantao
>
> Hi Xiantao,
>
> Good point, I hadn't spotted that, and worse I mangled
> flush_icache_range() in the process, trying to be smart :-(
>
> Here's a version without cache flush changes, it should do the right
> thing<tm>. We still need to look at the nvram stuff, but that is
> broken in all setups currently.
>
> What do you think of this one?

Hi, Jes
Except nvram stuff, I don't see the difference with my patch. Could you provide an incremental patch to fix nvram stuff ? :)
Xiantao