From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 03/04] qemu-kvm: Remove the dependency for phys_ram_base for ipf.c Date: Sun, 03 May 2009 19:14:14 +0300 Message-ID: <49FDC2D6.1080902@redhat.com> References: <706158FABBBA044BAD4FE898A02E4BC236A2BC04@pdsmsx503.ccr.corp.intel.com> <49F6D13C.1060908@redhat.com> <706158FABBBA044BAD4FE898A02E4BC236A2BC2D@pdsmsx503.ccr.corp.intel.com> <49F6E2DC.3070405@redhat.com> <49F6FB55.3000503@redhat.com> <706158FABBBA044BAD4FE898A02E4BC236A2BD9A@pdsmsx503.ccr.corp.intel.com> <49F80DFC.5060006@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236A2C04D@pdsmsx503.ccr.corp.intel.com> <49F812EF.5060006@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236A2C11C@pdsmsx503.ccr.corp.intel.com> <49FACF5F.8000305@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36487 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223AbZECQOS (ORCPT ); Sun, 3 May 2009 12:14:18 -0400 In-Reply-To: <49FACF5F.8000305@sgi.com> Sender: kvm-owner@vger.kernel.org List-ID: Jes Sorensen wrote: > Zhang, Xiantao wrote: >> Jes Sorensen wrote: >> I still can't see the difference with the patch in Avi's tree except >> nvram stuff. And I believe the global variable you mentioned should >> be only used for nvram. So I propose an incremental patch for that. :) > > Hi, > > Here is an incremental version of the patch. I think the differences > should be pretty obvious now :-) > > It fixes the memcpy issues in the hob and nvram code and also cleans > up the interfaces a lot. > > Avi, please add. Looks good to me. Xiantao? -- error compiling committee.c: too many arguments to function