From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, ehabkost@redhat.com
Subject: Re: [PATCH 2/2] Present kvm with corret apic phys id.
Date: Mon, 04 May 2009 11:32:40 +0300 [thread overview]
Message-ID: <49FEA828.1040406@redhat.com> (raw)
In-Reply-To: <1241037101-24842-3-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> KVM will 24-shift bits in addr 0x20 (APIC_ID) before actually
> using it. We currently load phys_id as "s->id". After shifted
> by 24 bits, it will result in a meaningless value. We should really
> be doing "s->id << 24", which, after shifted, will lead to the correct
> value.
>
> This is for the load function. save has the invert problem.
>
Applied, thanks.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-05-04 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-29 20:31 [PATCH 0/2] Fix cpu hotplug in upstream kvm Glauber Costa
2009-04-29 20:31 ` [PATCH 1/2] don't start cpu main loop while there is still init work to do Glauber Costa
2009-04-29 20:31 ` [PATCH 2/2] Present kvm with corret apic phys id Glauber Costa
2009-05-04 8:32 ` Avi Kivity [this message]
2009-05-04 8:30 ` [PATCH 1/2] don't start cpu main loop while there is still init work to do Avi Kivity
2009-05-04 14:26 ` Glauber Costa
2009-05-04 14:33 ` Avi Kivity
2009-05-04 14:44 ` Glauber Costa
2009-05-04 14:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FEA828.1040406@redhat.com \
--to=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox