From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 2/2] Present kvm with corret apic phys id.
Date: Mon, 04 May 2009 11:32:40 +0300
Message-ID: <49FEA828.1040406@redhat.com>
References: <1241037101-24842-1-git-send-email-glommer@redhat.com> <1241037101-24842-2-git-send-email-glommer@redhat.com> <1241037101-24842-3-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, ehabkost@redhat.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:50139 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752484AbZEDIdO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 4 May 2009 04:33:14 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n448XFOj023637
	for <kvm@vger.kernel.org>; Mon, 4 May 2009 04:33:15 -0400
In-Reply-To: <1241037101-24842-3-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Glauber Costa wrote:
> KVM will 24-shift bits in addr 0x20 (APIC_ID) before actually
> using it. We currently load phys_id as "s->id". After shifted
> by 24 bits, it will result in a meaningless value. We should really
> be doing "s->id << 24", which, after shifted, will lead to the correct
> value.
>
> This is for the load function. save has the invert problem.
>   

Applied, thanks.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.