From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 04/04] qemu-kvm: other archs should maintain memory mapping also. Date: Mon, 04 May 2009 11:59:25 +0300 Message-ID: <49FEAE6D.9040708@redhat.com> References: <706158FABBBA044BAD4FE898A02E4BC236A2BC03@pdsmsx503.ccr.corp.intel.com> <49F6CED2.1060202@redhat.com> <49F86CED.3010101@sgi.com> <49FEAE3A.2070001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , Hollis Blanchard , "kvm-ia64@vger.kernel.org" , kvm-devel , kvm-ppc To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60087 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbZEDJAD (ORCPT ); Mon, 4 May 2009 05:00:03 -0400 In-Reply-To: <49FEAE3A.2070001@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Jes Sorensen wrote: >> Avi Kivity wrote: >>> Hollis, does this work for you? >>> >>> If now, you can add a new define KVM_WANT_MAPPING or something, and >>> define it for I386 and IA64. >> >> >> Hi, >> >> This is the one implementing the KVM_WANT_MAPPING change. >> >> Cheers, >> Jes >> >> > > There is in fact a call to drop_mapping() outside any #ifdef (in > kvm_cpu_register_physical_memory()). I'm confused... maybe we should > make this code unconditional. > -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.