RE: [PATCH 02/04] qemu-kvm: Add header files for ia64.

Zhang, Xiantao
2009-04-29T09:45:22Z

Hi, Jes
There should be no issue here. You may refer to qemu-kvm/kvm/kernel/arch/x86/include/asm/kvm.h, and it also includes this stuff. I remebered this stuff was used to solve the issues when uses kernel header files in userspace and the author should be Avi:-) You know, kernel header may include CONFIG_$ARCH macros but they are meaningless in userspace, so needs a way to solve the gap. But anyway we can do some cleanup or introduce new ways to solve the issue.
Xiantao

-----Original Message-----
From: jes@jaguar.mkp.net [mailto:jes@jaguar.mkp.net] On Behalf Of Jes Sorensen
Sent: Wednesday, April 29, 2009 5:31 PM
To: Zhang, Xiantao
Cc: Avi Kivity; kvm-ia64@vger.kernel.org; kvm@vger.kernel.org
Subject: Re: [PATCH 02/04] qemu-kvm: Add header files for ia64.

>>>>> "Xiantao" == Zhang, Xiantao <xiantao.zhang@intel.com> writes:

Xiantao> From bbaeed10e1629a1c86a497e5a4e18e5d51b5df69 Mon Sep 17
Xiantao> 00:00:00 2001 From: Xiantao Zhang <xiantao.zhang@intel.com>
Xiantao> Date: Tue, 28 Apr 2009 15:05:30 +0800 Subject: [PATCH]
Xiantao> qemu-kvm: Add header files for ia64.

diff --git a/kvm/kernel/arch/ia64/include/asm/kvm.h b/kvm/kernel/arch/ia64/include/asm/kvm.h
new file mode 100644
index 0000000..73963e3
--- /dev/null
+++ b/kvm/kernel/arch/ia64/include/asm/kvm.h
@@ -0,0 +1,303 @@
+#ifndef KVM_UNIFDEF_H
+#define KVM_UNIFDEF_H
+
+#ifdef __i386__
+#ifndef CONFIG_X86_32
+#define CONFIG_X86_32 1
+#endif
+#endif

^^^^^^^^^

I don't think this needs to be included :-) I had the same stuff show
up in my headers after doing a git pull at some point. Do you want to
repost an updated version of this patch?

Cheers,
Jes