From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] kvm: x86: Allow PIT emulation without speaker port
Date: Mon, 04 May 2009 12:32:16 +0300 [thread overview]
Message-ID: <49FEB620.6040102@redhat.com> (raw)
In-Reply-To: <49F0CE5A.8040405@web.de>
Jan Kiszka wrote:
> The in-kernel speaker emulation is only a dummy and also unneeded from
> the performance point of view. Rather, it takes user space support to
> generate sound output on the host, e.g. console beeps.
>
> To allow this, introduce KVM_CREATE_PIT_NOSPKR which is simply
> KVM_CREATE_PIT without registration of the speaker_dev.
>
>
Nothing wrong with the patch, but let's make it a little more forward
looking. Have a CREATE_PIT2 (or something) which accepts a structure
with a flags field and some padding. Define the first flag as speaker
in kernel vs speaker in userspace.
This would allow us to hack the PIT some more in the future if we find
we need too.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
prev parent reply other threads:[~2009-05-04 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 20:23 [PATCH] kvm: x86: Allow PIT emulation without speaker port Jan Kiszka
2009-05-04 9:32 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49FEB620.6040102@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox