From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [RFC] Bring in all the Linux headers we depend on in QEMU Date: Mon, 04 May 2009 08:14:25 -0500 Message-ID: <49FEEA31.20409@codemonkey.ws> References: <49FE0E97.30602@codemonkey.ws> <49FE9ED0.7060301@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , kvm-devel To: Avi Kivity Return-path: Received: from mail-gx0-f166.google.com ([209.85.217.166]:49482 "EHLO mail-gx0-f166.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591AbZEDNO2 (ORCPT ); Mon, 4 May 2009 09:14:28 -0400 Received: by gxk10 with SMTP id 10so7761854gxk.13 for ; Mon, 04 May 2009 06:14:27 -0700 (PDT) In-Reply-To: <49FE9ED0.7060301@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: >> >> >> Developers, in particular, like to point things at their random >> kernel trees. In general though, relying on a full kernel source >> tree being available isn't a good idea. Kernel headers change >> dramatically across versions too so it's very likely that we would >> need to have a lot of #ifdefs dependent on kernel versions, or some >> of the uglier work arounds we have in usb-linux.c. >> >> I think the best way to avoid #ifdefs and dependencies on >> broken/incomplete glibc headers is to include all of the Linux >> headers we need within QEMU. The attached patch does just this. >> >> I think there's room for discussion about whether we really want to >> do this. We could potentially depend on some more common glibc >> headers (like asm/types.h) while bringing in less reliable headers >> (if_tun.h/virtio*). Including them all seems like the most robust >> solution to me though. >> >> Comments? > > I think we need to use the output of 'make headers-install', which > removes things like __user and CONFIG_*. I was thinking about that as a possibility too. We still need the same basic infrastructure though. Regards, Anthony Liguori