From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] [RFC] Bring in all the Linux headers we depend on in QEMU Date: Mon, 04 May 2009 16:28:16 +0300 Message-ID: <49FEED70.7020606@redhat.com> References: <49FE0E97.30602@codemonkey.ws> <49FE9069.7010201@mail.berlios.de> <49FEE9EC.6060604@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stefan Weil , "qemu-devel@nongnu.org" , kvm-devel To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52950 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbZEDN24 (ORCPT ); Mon, 4 May 2009 09:28:56 -0400 In-Reply-To: <49FEE9EC.6060604@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Stefan Weil wrote: >> Anthony Liguori schrieb: >> >> For Debian systems, those headers are installed by package >> linux-libc-dev. >> There are also packages for cross compilation in emdebian >> (linux-libc-dev-mips-cross, linux-libc-dev-powerpc-cross, ...). >> >> Yes, those headers did not always match the features of the current >> kernel, >> so --enable-kvm did not work. This is fixed now - there is a >> linux-libc-dev >> 2.6.29-3 which is up-to-date. >> >> So, at the moment I see no need to fill the QEMU source tree with >> linux header files. >> > > We can not just rely on everyone who uses QEMU to use the latest > version of Debian... > > The fact is, linux-libc-dev is *not* meant for applications to use as > the official kernel ABI. We shouldn't depend on it. At least on Fedora, kernel-headers is. It is installed in /usr/include/linux and is synced (sorta) to the installed kernel. Carrying a subset of kernel headers is a bit too much, IMO. kvm is a special case since it is available externally. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.