From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] Bring in all the Linux headers we depend on in QEMU Date: Mon, 04 May 2009 16:38:12 +0300 Message-ID: <49FEEFC4.6060008@redhat.com> References: <49FE0E97.30602@codemonkey.ws> <200905041329.30824.arnd@arndb.de> <49FEEBDD.3090102@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Arnd Bergmann , "qemu-devel@nongnu.org" , kvm-devel To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35870 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752496AbZEDNi6 (ORCPT ); Mon, 4 May 2009 09:38:58 -0400 In-Reply-To: <49FEEBDD.3090102@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: >>> >> >> I don't see the need to copy all the core headers. These should have >> been working for ages, and hardly ever see changes that are relevant >> to kvm. > > If we want to use virtio_*.h instead of duplicating the copies as we > are now, then we need all of the core headers too or else it won't be > able to compile on systems that do not have Linux libc headers (like > win32). qemu provides virtio, it doesn't consume it. We can merge the virtio headers and remove the linuxisms. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.