From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 0/3] generic hypercall support Date: Tue, 05 May 2009 16:36:00 +0300 Message-ID: <4A0040C0.1080102@redhat.com> References: <20090505132005.19891.78436.stgit@dev.haskins.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: Gregory Haskins Return-path: In-Reply-To: <20090505132005.19891.78436.stgit@dev.haskins.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Gregory Haskins wrote: > (Applies to Linus' tree, b4348f32dae3cb6eb4bc21c7ed8f76c0b11e9d6a) > > Please see patch 1/3 for a description. This has been tested with a KVM > guest on x86_64 and appears to work properly. Comments, please. > What about the hypercalls in include/asm/kvm_para.h? In general, hypercalls cannot be generic since each hypervisor implements its own ABI. The abstraction needs to be at a higher level (pv_ops is such a level). -- error compiling committee.c: too many arguments to function