From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] virtio-net: Fix save/load
Date: Wed, 06 May 2009 08:46:57 -0500
Message-ID: <4A0194D1.60905@codemonkey.ws>
References: <1232042731.20605.9.camel@bling> <4A013A75.9050405@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alex Williamson <alex.williamson@hp.com>,
	kvm-devel <kvm@vger.kernel.org>,
	Mark McLoughlin <markmc@redhat.com>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-qy0-f125.google.com ([209.85.221.125]:53352 "EHLO
	mail-qy0-f125.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753084AbZEFNyv (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 6 May 2009 09:54:51 -0400
Received: by qyk31 with SMTP id 31so204654qyk.33
        for <kvm@vger.kernel.org>; Wed, 06 May 2009 06:54:51 -0700 (PDT)
In-Reply-To: <4A013A75.9050405@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> Alex Williamson wrote:
>> We can't rely on build switches to tell us if a save image
>> includes a given field.  We also need to save status since
>> it's visible to the guest.  Draw another line in the sand
>> for broken save versions.  The version number should always
>> be updated when new values are saved and load should make
>> an attempt to set reasonable defaults for lower version save
>> images.
>>   
>
> I applied the the first part of this ancient patch.  Can't tell from 
> the thread what the consensus is for the rest.

Please don't bump the version number.  If you do, you'll be incompatible 
with upstream QEMU.  We have to coordinate version number changes or 
else we're going to guarantee that we break backwards compatibility down 
the road.

Regards,

Anthony Liguori