From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Alex Williamson <alex.williamson@hp.com>,
kvm-devel <kvm@vger.kernel.org>,
Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH] virtio-net: Fix save/load
Date: Wed, 06 May 2009 17:09:26 +0300 [thread overview]
Message-ID: <4A019A16.7090309@redhat.com> (raw)
In-Reply-To: <4A0194D1.60905@codemonkey.ws>
Anthony Liguori wrote:
> Avi Kivity wrote:
>> Alex Williamson wrote:
>>> We can't rely on build switches to tell us if a save image
>>> includes a given field. We also need to save status since
>>> it's visible to the guest. Draw another line in the sand
>>> for broken save versions. The version number should always
>>> be updated when new values are saved and load should make
>>> an attempt to set reasonable defaults for lower version save
>>> images.
>>>
>>
>> I applied the the first part of this ancient patch. Can't tell from
>> the thread what the consensus is for the rest.
>
> Please don't bump the version number. If you do, you'll be
> incompatible with upstream QEMU. We have to coordinate version number
> changes or else we're going to guarantee that we break backwards
> compatibility down the road.
>
I didn't.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-05-06 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 18:05 [PATCH] virtio-net: Fix save/load Alex Williamson
2009-01-15 18:21 ` Mark McLoughlin
2009-01-15 18:39 ` Alex Williamson
2009-01-15 18:51 ` Mark McLoughlin
2009-05-06 7:21 ` Avi Kivity
2009-05-06 13:46 ` Anthony Liguori
2009-05-06 14:09 ` Avi Kivity [this message]
2009-05-06 16:01 ` Alex Williamson
2009-05-07 10:11 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A019A16.7090309@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@hp.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox