From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] virtio-net: Fix save/load Date: Wed, 06 May 2009 17:09:26 +0300 Message-ID: <4A019A16.7090309@redhat.com> References: <1232042731.20605.9.camel@bling> <4A013A75.9050405@redhat.com> <4A0194D1.60905@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alex Williamson , kvm-devel , Mark McLoughlin To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41465 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754133AbZEFOKI (ORCPT ); Wed, 6 May 2009 10:10:08 -0400 In-Reply-To: <4A0194D1.60905@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Avi Kivity wrote: >> Alex Williamson wrote: >>> We can't rely on build switches to tell us if a save image >>> includes a given field. We also need to save status since >>> it's visible to the guest. Draw another line in the sand >>> for broken save versions. The version number should always >>> be updated when new values are saved and load should make >>> an attempt to set reasonable defaults for lower version save >>> images. >>> >> >> I applied the the first part of this ancient patch. Can't tell from >> the thread what the consensus is for the rest. > > Please don't bump the version number. If you do, you'll be > incompatible with upstream QEMU. We have to coordinate version number > changes or else we're going to guarantee that we break backwards > compatibility down the road. > I didn't. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.