public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Beth Kon <eak@us.ibm.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override
Date: Wed, 06 May 2009 18:35:20 -0400	[thread overview]
Message-ID: <4A0210A8.7030205@us.ibm.com> (raw)
In-Reply-To: <919A9099171C4C8DA5E9F653FEB82124@FSCPC>

Sebastian Herbszt wrote:
> Beth Kon wrote:
>> @@ -477,6 +480,7 @@ void wrmsr_smp(uint32_t index, uint64_t val)
>> #define QEMU_CFG_SIGNATURE  0x00
>> #define QEMU_CFG_ID         0x01
>> #define QEMU_CFG_UUID       0x02
>> +#define QEMU_CFG_IRQ0_OVERRIDE 0x0e
>
> Small thing to consider before you resubmit:
> In his patch "read-additional-acpi-tables-from-a-vm.patch" Gleb 
> introduced:
>
> #define QEMU_CFG_ARCH_LOCAL     0x8000
> #define QEMU_CFG_ACPI_TABLES  (QEMU_CFG_ARCH_LOCAL + 0)
>
> I think the idea behind this was to seperate the generic part from 
> arch specific.
> The IRQ0 override seems to be arch specific (x86 only?) just like the 
> ACPI tables, right?
I'm not sure what the intent is. It looks like it would be just for 
additional tables (as opposed to "local")? Gleb? I don't believe irq0 
override would fall into that category. But in any case since this is 
not in any code base, I don't think there's anything to be done yet.
>
> - Sebastian
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2009-05-06 22:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 21:09 [PATCH 1/4] BIOS changes for configuring irq0->inti2 override Beth Kon
2009-05-04 21:09 ` [PATCH 2/4] Userspace " Beth Kon
2009-05-04 21:09 ` [PATCH 3/4] BIOS changes for KVM HPET Beth Kon
2009-05-04 21:09 ` [PATCH 4/4] Userspace " Beth Kon
2009-05-05 17:12 ` [PATCH 1/4] BIOS changes for configuring irq0->inti2 override Beth Kon
2009-05-05 21:38 ` Sebastian Herbszt
2009-05-06 22:35   ` Beth Kon [this message]
2009-05-07  5:42     ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0210A8.7030205@us.ibm.com \
    --to=eak@us.ibm.com \
    --cc=gleb@redhat.com \
    --cc=herbszt@gmx.de \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox