From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jes Sorensen <jes@sgi.com>
Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled
Date: Thu, 07 May 2009 10:14:09 +0200
Message-ID: <4A029851.3030503@sgi.com>
References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>,
	"kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from relay1.sgi.com ([192.48.179.29]:37970 "EHLO relay.sgi.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1750954AbZEGION (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 7 May 2009 04:14:13 -0400
In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Zhang, Xiantao wrote:
> --- qemu-kvm.orig/vl.c
> +++ qemu-kvm/vl.c
> @@ -4417,13 +4417,11 @@
>          }
>          if (cpu_can_run(env))
>              ret = qemu_cpu_exec(env);
> -#ifndef CONFIG_GDBSTUB
> ^^^^^^^^^^^
> Don't know why change #ifdef to #ifndef in upstream, and I remember it should be ifdef before. I believe this stuff should be compiled only if CONFIG_GDBSTUB is defined.  

Yes, I made get_set_top_cpu() a noop instead when compiled with
CONFIG_GDBSTUB disabled, that way we avoid a bunch of these silly
#ifdefs.

Cheers,
Jes