From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled Date: Thu, 07 May 2009 12:51:19 +0200 Message-ID: <4A02BD27.5050401@siemens.com> References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com> <4A02AA81.90809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , Jes Sorensen , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" , qemu-devel To: Avi Kivity Return-path: Received: from gecko.sbs.de ([194.138.37.40]:21322 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbZEGKwD (ORCPT ); Thu, 7 May 2009 06:52:03 -0400 In-Reply-To: <4A02AA81.90809@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Zhang, Xiantao wrote: >> Jes Sorensen wrote: >> >>> Hi, >>> >>> The latest changes to qemu-kvm breaks miserably if one tries to build >>> without CONFIG_GDBSTUB. >>> >>> Jes >>> >> >> --- qemu-kvm.orig/vl.c >> +++ qemu-kvm/vl.c >> @@ -4417,13 +4417,11 @@ >> } >> if (cpu_can_run(env)) >> ret = qemu_cpu_exec(env); >> -#ifndef CONFIG_GDBSTUB >> ^^^^^^^^^^^ >> Don't know why change #ifdef to #ifndef in upstream, and I remember it >> should be ifdef before. I believe this stuff should be compiled only >> if CONFIG_GDBSTUB is defined. > > This was introduced by > > commit 704aec581c1683750e313832ba3aa4813d59cbd0 > Author: Xiantao Zhang > Date: Thu Nov 27 17:23:27 2008 +0800 > > Build fix for !CONFIG_GDBSTUB case > Once CONFIG_GDBSTUB not configured, compile will generate error > > In upstream. Please fix it in upstream and qemu-kvm.git will get the > fix from there. Given that CONFIG_GDBSTUB is always true upstream, I tend to say: Finally drop it upstream and keep this (or a more arch-local) workaround for missing ia64 gdbstub support downstream. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux