From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled Date: Thu, 07 May 2009 13:13:59 +0200 Message-ID: <4A02C277.4000402@siemens.com> References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com> <4A02AA81.90809@redhat.com> <4A02BD27.5050401@siemens.com> <4A02BF59.6030103@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , Jes Sorensen , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" , qemu-devel To: Avi Kivity Return-path: Received: from lizzard.sbs.de ([194.138.37.39]:17424 "EHLO lizzard.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028AbZEGLO3 (ORCPT ); Thu, 7 May 2009 07:14:29 -0400 In-Reply-To: <4A02BF59.6030103@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Jan Kiszka wrote: >>> In upstream. Please fix it in upstream and qemu-kvm.git will get the >>> fix from there. >>> >> >> Given that CONFIG_GDBSTUB is always true upstream, I tend to say: >> Finally drop it upstream and keep this (or a more arch-local) workaround >> for missing ia64 gdbstub support downstream. >> > > I agree, unless > > - we want to make gdbstub support configurable (don't see any > overwhelming reason for this, but maybe others do) > - we want to merge ia64 kvm support upstream, and don't want to impose > gdbstub support (though I'd recommend properly implementing gdbstub) > > In any case, I'm okay with dropping the check upstream and applying the > local fixup. The last ia64 tcg patch I saw one or two days ago was missing gdb support, too (and may suffer from some brokenness for that reason). But I would suggest for both cases (tcg and kvm) to temporarily provide stubs/placeholders instead of keeping the central #ifdefs. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux