From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled Date: Thu, 07 May 2009 14:28:49 +0300 Message-ID: <4A02C5F1.4060205@redhat.com> References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com> <4A02AA81.90809@redhat.com> <4A02BD27.5050401@siemens.com> <4A02BF59.6030103@redhat.com> <4A02C277.4000402@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Zhang, Xiantao" , Jes Sorensen , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" , qemu-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52083 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753330AbZEGL2z (ORCPT ); Thu, 7 May 2009 07:28:55 -0400 In-Reply-To: <4A02C277.4000402@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: >> I agree, unless >> >> - we want to make gdbstub support configurable (don't see any >> overwhelming reason for this, but maybe others do) >> - we want to merge ia64 kvm support upstream, and don't want to impose >> gdbstub support (though I'd recommend properly implementing gdbstub) >> >> In any case, I'm okay with dropping the check upstream and applying the >> local fixup. >> > > The last ia64 tcg patch I saw one or two days ago was missing gdb > support, too (and may suffer from some brokenness for that reason). I didn't see ia64/tcg. Did you mean s390? That was host only IIRC. > But > I would suggest for both cases (tcg and kvm) to temporarily provide > stubs/placeholders instead of keeping the central #ifdefs. > Agreed. -- error compiling committee.c: too many arguments to function