From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 0/3] generic hypercall support Date: Thu, 07 May 2009 22:26:03 +0300 Message-ID: <4A0335CB.5010408@redhat.com> References: <4A031471.7000406@novell.com> <4A0322F1.2000905@redhat.com> <4A032390.6030100@gmail.com> <4A032472.4030106@redhat.com> <4A03259B.3050500@gmail.com> <4A032771.6050703@redhat.com> <4A032A74.2020809@novell.com> <4A032FDD.8020209@redhat.com> <20090507190751.GE3036@sequoia.sous-sol.org> <4A033281.8050002@novell.com> <20090507192145.GF3036@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gregory Haskins , Gregory Haskins , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Anthony Liguori To: Chris Wright Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41657 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbZEGT1i (ORCPT ); Thu, 7 May 2009 15:27:38 -0400 In-Reply-To: <20090507192145.GF3036@sequoia.sous-sol.org> Sender: kvm-owner@vger.kernel.org List-ID: Chris Wright wrote: > * Gregory Haskins (ghaskins@novell.com) wrote: > >> Chris Wright wrote: >> >>> * Avi Kivity (avi@redhat.com) wrote: >>> >>>> Gregory Haskins wrote: >>>> >>>>> Cool, I will code this up and submit it. While Im at it, Ill run it >>>>> through the "nullio" ringer, too. ;) It would be cool to see the >>>>> pv-mmio hit that 2.07us number. I can't think of any reason why this >>>>> will not be the case. >>>>> >>>>> >>>> Don't - it's broken. It will also catch device assignment mmio and >>>> hypercall them. >>>> >>> Not necessarily. It just needs to be creative w/ IO_COND >>> >> Hi Chris, >> Could you elaborate? How would you know which pages to hypercall and >> which to let PF? >> > > Was just thinking of some ugly mangling of the addr (I'm not entirely > sure what would work best). > I think we just past the "too complicated" threshold. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.