From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] kvm: Add support for querying supported cpu features Date: Sat, 09 May 2009 11:41:13 +0300 Message-ID: <4A0541A9.6060800@redhat.com> References: <1241359444-8538-1-git-send-email-avi@redhat.com> <1241359444-8538-2-git-send-email-avi@redhat.com> <4A049B0B.9030405@us.ibm.com> <4A049F96.90502@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50984 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922AbZEIIlQ (ORCPT ); Sat, 9 May 2009 04:41:16 -0400 In-Reply-To: <4A049F96.90502@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Anthony Liguori wrote: >> >> kvm_check_extension doesn't exist in upstream QEMU. It's a good idea >> though so I added it in a previous commit. However, I changed the >> signature to it to take a KVMState * as the first argument (which is >> available in env->kvm_state). I updated this patch to pass the extra >> 's' parameter. > > Ah, you had a patch, I just didn't notice in my queue. > Yeah, I should have made the dependency explicit. > Still wanted to make the KVMState change though. > I think the KVM_REQUIRE_EXTENSION bit didn't like it. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.