From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Implement generic double fault generation mechanism Date: Mon, 11 May 2009 09:17:40 +0300 Message-ID: <4A07C304.2000208@redhat.com> References: <9832F13BD22FB94A829F798DA4A8280501A80F02A3@pdsmsx503.ccr.corp.intel.com> <20090503105330.GL9795@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A81A8E83@pdsmsx503.ccr.corp.intel.com> <20090508095336.GD25357@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A81A8EFE@pdsmsx503.ccr.corp.intel.com> <9832F13BD22FB94A829F798DA4A8280501A81A8F02@pdsmsx503.ccr.corp.intel.com> <20090508122358.GF25357@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A81A8F2B@pdsmsx503.ccr.corp.intel.com> <20090508184417.GA27255@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A81A9078@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , "kvm@vger.kernel.org" To: "Dong, Eddie" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33396 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbZEKGSN (ORCPT ); Mon, 11 May 2009 02:18:13 -0400 In-Reply-To: <9832F13BD22FB94A829F798DA4A8280501A81A9078@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Dong, Eddie wrote: >> There is not point referring to current code. Current code does not >> handle serial exceptions properly. So fix it in your patch otherwise I >> propose to use my patch that fixes current code >> (http://patchwork.kernel.org/patch/21829/). >> >> > > I would like Avi to decide. I would prefer you two to reach agreement. Less work for me. > I can check with internal architecture to see what does "handle exceptions serially" mean in really. For me serial means first in first out, and thus we should remain 1st exception. > The second exception was encountered while injecting the first exception, so how can you continue with the first without servicing the second? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.