From mboxrd@z Thu Jan  1 00:00:00 1970
From: Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH -tip v5 5/7] x86: fix kernel_trap_sp()
Date: Mon, 11 May 2009 09:48:52 -0400
Message-ID: <4A082CC4.5000601@redhat.com>
References: <20090509004829.5505.38720.stgit@localhost.localdomain> <20090509004904.5505.59034.stgit@localhost.localdomain> <20090511092841.GB23875@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,         lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>,         Harvey Harrison <harvey.harrison@gmail.com>,         Thomas Gleixner <tglx@linutronix.de>, Jan Blunck <jblunck@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Return-path: <systemtap-return-12294-gls-systemtap=m.gmane.org@sourceware.org>
In-Reply-To: <20090511092841.GB23875@infradead.org>
List-Unsubscribe: <mailto:systemtap-unsubscribe-gls-systemtap=m.gmane.org@sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
List-Id: kvm.vger.kernel.org

Christoph Hellwig wrote:
> On Fri, May 08, 2009 at 08:49:04PM -0400, Masami Hiramatsu wrote:
>> Use &regs->sp instead of regs for getting the top of stack in kernel mode.
>> (on x86-64, regs->sp always points the top of stack)
> 
> Shouldn't this patch be sent for inclusion ASAP instead of sitting in
> this series?

Yes, and it's just for asking a comment from oprofile developers,
because this change will change its behavior a bit.

Anyway, I'll post it separately against upstream.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com