From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Burns Subject: Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install Date: Mon, 11 May 2009 14:43:04 -0400 Message-ID: <4A0871B8.309@redhat.com> References: <443364434.369371242063386949.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <4A0865D3.7020500@redhat.com> <20090511183450.GJ4871@blackpad> Reply-To: mburns@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: Michael Goldish , kvm@vger.kernel.org, Uri Lublin To: Eduardo Habkost Return-path: Received: from mx2.redhat.com ([66.187.237.31]:51082 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbZEKSnF (ORCPT ); Mon, 11 May 2009 14:43:05 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4BIh6SK030489 for ; Mon, 11 May 2009 14:43:07 -0400 In-Reply-To: <20090511183450.GJ4871@blackpad> Sender: kvm-owner@vger.kernel.org List-ID: Eduardo Habkost wrote: > On Mon, May 11, 2009 at 01:52:19PM -0400, Mike Burns wrote: > >> Michael Goldish wrote: >> > > >>> 2. Why not just pass the parameters via the command line, e.g. >>> install_command = my_script.sh param1 param2 >>> >>> >> That would work as well. It could be done either way, but if someone >> wanted to use something other than bash, then this way might be easier. >> > > What is bash-specific about environment variables or command-line args? > > Also, exporting the config dictionary as environment variables doesn't > exclude the possibility of simply passing command-line arguments on > install_command, if the user wants to do so. Both methods would work. > > I suppose it doesn't. I've found that some languages make it easier to deal with command line as opposed to environment, but both would work.