public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Beth Kon <eak@us.ibm.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/4] Userspace changes for configuring irq0->inti2	override (v3)
Date: Tue, 12 May 2009 13:22:06 +0300	[thread overview]
Message-ID: <4A094DCE.3080109@redhat.com> (raw)
In-Reply-To: <20090512095345.GB19446@redhat.com>

Gleb Natapov wrote:
>>          for (i = 0; i < 24; ++i) {
>> -            r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, i);
>> +            if (i == 0) {
>> +                r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, 2);
>> +            } else if (i != 2) {
>> +                r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, i);
>> +            }
>>     
> There is no entry for IRQ2, is this OK? What happens if IRQ2 triggers?
>   

irq 2 is the PIC cascade interrupt.  If it is somehow triggered, the 
kernel will ignore it.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-05-12 10:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 17:29 [PATCH 1/4] BIOS changes for configuring irq0->inti2 override (v3) Beth Kon
2009-05-11 17:29 ` [PATCH 2/4] Userspace " Beth Kon
2009-05-12  9:53   ` Gleb Natapov
2009-05-12 10:22     ` Avi Kivity [this message]
2009-05-12 10:52       ` Gleb Natapov
2009-05-12 13:20         ` [PATCH 2/4] Userspace changes for configuring irq0->inti2override (v3) Beth Kon
2009-05-12 13:37           ` Gleb Natapov
2009-05-12 13:29     ` Beth Kon
2009-05-11 17:29 ` [PATCH 3/4] BIOS changes for KVM HPET (v3) Beth Kon
2009-05-11 17:29 ` [PATCH 4/4] Userspace " Beth Kon
2009-05-12  9:03   ` Avi Kivity
2009-05-12 14:25     ` Beth Kon
2009-05-12 16:27       ` Beth Kon
2009-05-13  7:48         ` Avi Kivity
2009-05-13  7:50           ` Avi Kivity
2009-05-12  9:57 ` [PATCH 1/4] BIOS changes for configuring irq0->inti2 override (v3) Gleb Natapov
2009-05-12 13:59   ` [PATCH 1/4] BIOS changes for configuring irq0->inti2 override(v3) Beth Kon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A094DCE.3080109@redhat.com \
    --to=avi@redhat.com \
    --cc=eak@us.ibm.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox