From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 2/4] Userspace changes for configuring irq0->inti2	override
  (v3)
Date: Tue, 12 May 2009 13:22:06 +0300
Message-ID: <4A094DCE.3080109@redhat.com>
References: <1242062986-29383-1-git-send-email-eak@us.ibm.com> <1242062986-29383-2-git-send-email-eak@us.ibm.com> <20090512095345.GB19446@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Beth Kon <eak@us.ibm.com>, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:45698 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751270AbZELKYO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 May 2009 06:24:14 -0400
In-Reply-To: <20090512095345.GB19446@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Gleb Natapov wrote:
>>          for (i = 0; i < 24; ++i) {
>> -            r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, i);
>> +            if (i == 0) {
>> +                r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, 2);
>> +            } else if (i != 2) {
>> +                r = kvm_add_irq_route(kvm_context, i, KVM_IRQCHIP_IOAPIC, i);
>> +            }
>>     
> There is no entry for IRQ2, is this OK? What happens if IRQ2 triggers?
>   

irq 2 is the PIC cascade interrupt.  If it is somehow triggered, the 
kernel will ignore it.

-- 
error compiling committee.c: too many arguments to function