Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override(v3)

[Beth Kon <eak@us.ibm.com>]

Gleb Natapov wrote:
> On Mon, May 11, 2009 at 01:29:43PM -0400, Beth Kon wrote:
>   
>> Signed-off-by: Beth Kon <eak@us.ibm.com>
>>
>> diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c
>> index cbd5f15..53359b8 100755
>> --- a/kvm/bios/rombios32.c
>> +++ b/kvm/bios/rombios32.c
>> @@ -444,6 +444,9 @@ uint32_t cpuid_features;
>>  uint32_t cpuid_ext_features;
>>  unsigned long ram_size;
>>  uint64_t ram_end;
>> +#ifdef BX_QEMU
>> +uint8_t irq0_override;
>> +#endif
>>  #ifdef BX_USE_EBDA_TABLES
>>  unsigned long ebda_cur_addr;
>>  #endif
>> @@ -485,6 +488,7 @@ void wrmsr_smp(uint32_t index, uint64_t val)
>>  #define QEMU_CFG_ARCH_LOCAL     0x8000
>>  #define QEMU_CFG_ACPI_TABLES  (QEMU_CFG_ARCH_LOCAL + 0)
>>  #define QEMU_CFG_SMBIOS_ENTRIES  (QEMU_CFG_ARCH_LOCAL + 1)
>> +#define QEMU_CFG_IRQ0_OVERRIDE   (QEMU_CFG_ARCH_LOCAL + 2)
>>  
>>  int qemu_cfg_port;
>>  
>> @@ -553,6 +557,18 @@ uint64_t qemu_cfg_get64 (void)
>>  }
>>  #endif
>>  
>> +#ifdef BX_QEMU
>> +void irq0_override_probe(void)
>> +{
>> +    if(qemu_cfg_port) {
>> +        qemu_cfg_select(QEMU_CFG_IRQ0_OVERRIDE);
>> +        qemu_cfg_read(&irq0_override, 1);
>> +        return;
>> +    }
>> +    memset(&irq0_override, 0, 1);
>> +}
>>     
> Why memset and not irq0_override = 0, actually it should zero already.
>
>   
This was an oversight, left over from some early cut-and-paste coding I 
was doing. You're right - not necessary. Thanks.
> --
> 			Gleb.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>