From mboxrd@z Thu Jan 1 00:00:00 1970 From: Beth Kon Subject: Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override(v3) Date: Tue, 12 May 2009 09:59:21 -0400 Message-ID: <4A0980B9.7090509@us.ibm.com> References: <1242062986-29383-1-git-send-email-eak@us.ibm.com> <20090512095722.GC19446@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: avi@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:44683 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbZELN6k (ORCPT ); Tue, 12 May 2009 09:58:40 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e32.co.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4CDtKHJ001613 for ; Tue, 12 May 2009 07:55:20 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4CDweUp073016 for ; Tue, 12 May 2009 07:58:40 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4CDwdc5023447 for ; Tue, 12 May 2009 07:58:40 -0600 In-Reply-To: <20090512095722.GC19446@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > On Mon, May 11, 2009 at 01:29:43PM -0400, Beth Kon wrote: > >> Signed-off-by: Beth Kon >> >> diff --git a/kvm/bios/rombios32.c b/kvm/bios/rombios32.c >> index cbd5f15..53359b8 100755 >> --- a/kvm/bios/rombios32.c >> +++ b/kvm/bios/rombios32.c >> @@ -444,6 +444,9 @@ uint32_t cpuid_features; >> uint32_t cpuid_ext_features; >> unsigned long ram_size; >> uint64_t ram_end; >> +#ifdef BX_QEMU >> +uint8_t irq0_override; >> +#endif >> #ifdef BX_USE_EBDA_TABLES >> unsigned long ebda_cur_addr; >> #endif >> @@ -485,6 +488,7 @@ void wrmsr_smp(uint32_t index, uint64_t val) >> #define QEMU_CFG_ARCH_LOCAL 0x8000 >> #define QEMU_CFG_ACPI_TABLES (QEMU_CFG_ARCH_LOCAL + 0) >> #define QEMU_CFG_SMBIOS_ENTRIES (QEMU_CFG_ARCH_LOCAL + 1) >> +#define QEMU_CFG_IRQ0_OVERRIDE (QEMU_CFG_ARCH_LOCAL + 2) >> >> int qemu_cfg_port; >> >> @@ -553,6 +557,18 @@ uint64_t qemu_cfg_get64 (void) >> } >> #endif >> >> +#ifdef BX_QEMU >> +void irq0_override_probe(void) >> +{ >> + if(qemu_cfg_port) { >> + qemu_cfg_select(QEMU_CFG_IRQ0_OVERRIDE); >> + qemu_cfg_read(&irq0_override, 1); >> + return; >> + } >> + memset(&irq0_override, 0, 1); >> +} >> > Why memset and not irq0_override = 0, actually it should zero already. > > This was an oversight, left over from some early cut-and-paste coding I was doing. You're right - not necessary. Thanks. > -- > Gleb. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >