Re: [PATCH 4/4] Userspace changes for KVM HPET (v3)

[Avi Kivity <avi@redhat.com>]

Avi Kivity wrote:
>>> My assumption about hpet_load was that the correct pit state would 
>>> be established via pit_load (since all saves/loads are done 
>>> together).  But when I wrote this, I was thinking only about the 
>>> userspace pit (for qemu). I'm not sure how the "load" concept 
>>> applies to kernel state.  Do I need to explicitly re-enable or 
>>> disable the kernel pit during load?
>> Looking further at the code, it looks like kvm_pit_load should take 
>> care of this. Agree?
>>
>
> I doesn't save/load the "enabled" bit, does it?
>

Also, we might migrate between a host with pit-in-kernel and a host with 
pit-in-userspace, so this is should be handled at the pit level, not kvm.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.