From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] don't use a 32-bit bit type as offset argument.
Date: Wed, 13 May 2009 16:43:21 -0500
Message-ID: <4A0B3EF9.1050105@codemonkey.ws>
References: <1242242474-7599-1-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, avi@redhat.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from an-out-0708.google.com ([209.85.132.244]:37465 "EHLO
	an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752669AbZEMVnY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 13 May 2009 17:43:24 -0400
Received: by an-out-0708.google.com with SMTP id d40so1590762and.1
        for <kvm@vger.kernel.org>; Wed, 13 May 2009 14:43:25 -0700 (PDT)
In-Reply-To: <1242242474-7599-1-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Glauber Costa wrote:
> In the call path of kvm_get_dirty_pages_log_range(),
> its caller kvm_get_dirty_bitmap_cb() passes the
> target_phys_addr_t both as start_addr and the offset.
> So, using int will make dirty tracking over 4G fail
> completely.
>
> Of course we should be using qemu types in
> here, so please don't get me started on this. The whole
> file is wrong already ;)
>   

:-)

> Signed-off-by: Glauber Costa <glommer@redhat.com>
>   

Good candidate for stable too.

Regards,

Anthony Liguori