From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] don't use a 32-bit bit type as offset argument.
Date: Thu, 14 May 2009 15:16:11 +0300 [thread overview]
Message-ID: <4A0C0B8B.4020605@redhat.com> (raw)
In-Reply-To: <1242242474-7599-1-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> In the call path of kvm_get_dirty_pages_log_range(),
> its caller kvm_get_dirty_bitmap_cb() passes the
> target_phys_addr_t both as start_addr and the offset.
> So, using int will make dirty tracking over 4G fail
> completely.
>
>
Applied, thanks.
> Of course we should be using qemu types in
> here, so please don't get me started on this. The whole
> file is wrong already ;)
>
These callbacks are called from libkvm, which doesn't know much about qemu.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-05-14 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 19:21 [PATCH] don't use a 32-bit bit type as offset argument Glauber Costa
2009-05-13 20:23 ` Ryan Harper
2009-05-13 20:36 ` Glauber Costa
2009-05-13 21:43 ` Anthony Liguori
2009-05-14 12:16 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C0B8B.4020605@redhat.com \
--to=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox