From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] don't use a 32-bit bit type as offset argument. Date: Thu, 14 May 2009 15:16:11 +0300 Message-ID: <4A0C0B8B.4020605@redhat.com> References: <1242242474-7599-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55305 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752551AbZENMQM (ORCPT ); Thu, 14 May 2009 08:16:12 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4ECGD0n004016 for ; Thu, 14 May 2009 08:16:13 -0400 In-Reply-To: <1242242474-7599-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > In the call path of kvm_get_dirty_pages_log_range(), > its caller kvm_get_dirty_bitmap_cb() passes the > target_phys_addr_t both as start_addr and the offset. > So, using int will make dirty tracking over 4G fail > completely. > > Applied, thanks. > Of course we should be using qemu types in > here, so please don't get me started on this. The whole > file is wrong already ;) > These callbacks are called from libkvm, which doesn't know much about qemu. -- error compiling committee.c: too many arguments to function