From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR) Date: Thu, 14 May 2009 18:55:32 +0300 Message-ID: <4A0C3EF4.3080708@redhat.com> References: <1242203541-12959-1-git-send-email-markmc@redhat.com> <200905132157.02633.arnd@arndb.de> <4A0BD02B.1020009@redhat.com> <200905141749.54453.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark McLoughlin , kvm@vger.kernel.org To: Arnd Bergmann Return-path: Received: from mx2.redhat.com ([66.187.237.31]:47551 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbZENPzg (ORCPT ); Thu, 14 May 2009 11:55:36 -0400 In-Reply-To: <200905141749.54453.arnd@arndb.de> Sender: kvm-owner@vger.kernel.org List-ID: Arnd Bergmann wrote: > On Thursday 14 May 2009, Avi Kivity wrote: > >> There aren't the real kernel headers, just cheap copies carried in >> qemu-kvm.git which have been appropriately postprocessed. We do this >> since the kvm external module can run on a much older kernel, so there >> is no natural place to find it headers. >> > > Sorry for the confusion on my part. I was aware of the sanitized > kernel headers, but was mislead by the line > > kerneldir=/lib/modules/$(uname -r)/build > > in kvm/user/configure. What I didn't realize is that this > always gets overridden by kvm/configure. > Maybe we can change the default in kvm/user/configure to > something more sensible: > --- > [PATCH] kvm: user: fix default kerneldir > > calling ./configure in kvm/user sets the kerneldir to the > currently running kernel, which is incorrect for user code. > This changes the default to the sanitized header files from > the kvm/kernel directory. > > Signed-off-by: Arnd Bergmann > > diff --git a/kvm/user/configure b/kvm/user/configure > index efb8705..858a519 100755 > --- a/kvm/user/configure > +++ b/kvm/user/configure > @@ -1,7 +1,7 @@ > #!/bin/bash > > prefix=/usr/local > -kerneldir=/lib/modules/$(uname -r)/build > +kerneldir="$(dirname $0)/../kernel" > cc=gcc > ld=ld > objcopy=objcopy > I usually add a readlink -f in there due to my innate fear of relative directories and cd. btw, these are my plans for kvm/user: - convert the tests to be loadable with qemu -kernel; we lose the simplicity of kvmctl so I'm not 100% sure it's a good idea. On the other hand some of the tests are useful for tcg. - kill kvmtrace (replaced by the standard ftrace tools, whatever they are; maybe create a new repo if kvm specific tools are needed) -- error compiling committee.c: too many arguments to function