From: Avi Kivity <avi@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com
Subject: Re: [PATCH] Don't try to mess with CPUID when running nested SVM
Date: Fri, 15 May 2009 14:09:54 +0300 [thread overview]
Message-ID: <4A0D4D82.1030903@redhat.com> (raw)
In-Reply-To: <1242378078-1908-2-git-send-email-agraf@suse.de>
Alexander Graf wrote:
> When using nested SVM we usually want the guest to see the exact CPUID values
> we gave it and not some mangled ones.
>
That would triggered by -cpu host, not nesting.
> @@ -1506,7 +1506,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
> *edx = env->cpuid_features;
>
> /* "Hypervisor present" bit required for Microsoft SVVP */
> - if (kvm_enabled())
> + if (kvm_enabled() && !kvm_nested)
> *ecx |= (1 << 31);
> break;
>
-cpu host,-hypervisor
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2009-05-15 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 9:01 [PATCH] Add external-module-compat header for MSR_VM_IGNNE Alexander Graf
2009-05-15 9:01 ` [PATCH] Don't try to mess with CPUID when running nested SVM Alexander Graf
2009-05-15 11:09 ` Avi Kivity [this message]
2009-05-15 11:15 ` Alexander Graf
2009-05-15 11:19 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0D4D82.1030903@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox