From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Don't try to mess with CPUID when running nested SVM
Date: Fri, 15 May 2009 14:09:54 +0300
Message-ID: <4A0D4D82.1030903@redhat.com>
References: <1242378078-1908-1-git-send-email-agraf@suse.de> <1242378078-1908-2-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:37899 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754117AbZEOLJ5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 15 May 2009 07:09:57 -0400
In-Reply-To: <1242378078-1908-2-git-send-email-agraf@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Alexander Graf wrote:
> When using nested SVM we usually want the guest to see the exact CPUID values
> we gave it and not some mangled ones.
>   

That would triggered by -cpu host, not nesting.

> @@ -1506,7 +1506,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
>          *edx = env->cpuid_features;
>  
>          /* "Hypervisor present" bit required for Microsoft SVVP */
> -        if (kvm_enabled())
> +        if (kvm_enabled() && !kvm_nested)
>              *ecx |= (1 << 31);
>          break;
>   

-cpu host,-hypervisor

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.