From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/17] Stop/start cpus before/after devices Date: Sun, 17 May 2009 19:59:51 +0300 Message-ID: <4A104287.6080000@redhat.com> References: <1242574999-20887-1-git-send-email-aliguori@us.ibm.com> <1242574999-20887-6-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Glauber Costa , Yaniv Kamay , Marcelo Tosatti To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48153 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbZEQQ7x (ORCPT ); Sun, 17 May 2009 12:59:53 -0400 In-Reply-To: <1242574999-20887-6-git-send-email-aliguori@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > From: Yaniv Kamay > > Stop cpus before devices when stopping the VM, start cpus after devices > when starting VM. Otherwise a vcpu could access a stopped device. > > IIRC we decided this was unnecessary since everything is under qemu_mutex. However we might want to be on the safe side here and be similar to master. Marcelo? -- error compiling committee.c: too many arguments to function