From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 5/6] Nested SVM: Implement INVLPGA
Date: Sun, 17 May 2009 23:03:52 +0300
Message-ID: <4A106DA8.6070200@redhat.com>
References: <1242375740-31222-1-git-send-email-agraf@suse.de> <1242375740-31222-2-git-send-email-agraf@suse.de> <1242375740-31222-3-git-send-email-agraf@suse.de> <1242375740-31222-4-git-send-email-agraf@suse.de> <1242375740-31222-5-git-send-email-agraf@suse.de> <1242375740-31222-6-git-send-email-agraf@suse.de> <20090515134301.GX9835@amd.com> <4A106D49.7080600@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:54045 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754411AbZEQUD5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 17 May 2009 16:03:57 -0400
In-Reply-To: <4A106D49.7080600@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
>>
>> Hmm, since we flush the TLB on every nested-guest entry I think we can
>> make this function a nop.
>>   
>
> I think, unless it specified ASID 0?  In that case you need a local 
> tlb flush.
>
> (the kvm_mmu_reset_context() and kvm_mmu_load() are total overkills in 
> any case).
>

Oh, but we do need to resync OOS pages, here for ASID 0 and on guest 
entry.  Marcelo?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.