From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
kvm@vger.kernel.org, sheng.yang@intel.com
Subject: Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs
Date: Sun, 17 May 2009 23:49:31 +0300 [thread overview]
Message-ID: <4A10785B.8090906@redhat.com> (raw)
In-Reply-To: <1242217175.4786.50.camel@2710p.home>
Alex Williamson wrote:
> On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote:
>
>> On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote:
>>
>>> @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks,
>>> int fd;
>>> kvm_context_t kvm;
>>> int r;
>>> +#ifdef KVM_CAP_IRQ_ROUTING
>>>
>> Let's kill all these ifdefs. Or at least, let's not add them.
>>
>
> AFAICT, they're still used both for builds against older kernels and
> architectures that don't support it. Hollis just added the one around
> kvm_get_irq_route_gsi() 10 days ago to fix ppc build. Has it since been
> deprecated? Thanks,
>
They are somewhat documentary. They used to be needed since we
supported building against any kernel header, but aren't strictly needed
now. Let's keep them until we have Documentation/kvm/extensions.txt.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-05-17 20:49 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 22:22 [PATCH] kvm: Use a bitmap for tracking used GSIs Alex Williamson
2009-05-08 22:31 ` [PATCH v2] " Alex Williamson
2009-05-12 19:39 ` Michael S. Tsirkin
2009-05-12 21:56 ` Alex Williamson
2009-05-12 22:07 ` [PATCH v3] " Alex Williamson
2009-05-13 3:30 ` Yang, Sheng
2009-05-13 3:42 ` Alex Williamson
2009-05-13 4:10 ` Alex Williamson
2009-05-13 4:15 ` Yang, Sheng
2009-05-13 4:41 ` [PATCH v4] " Alex Williamson
2009-05-13 4:58 ` Yang, Sheng
2009-05-13 9:47 ` Avi Kivity
2009-05-13 12:28 ` Alex Williamson
2009-05-13 12:35 ` Avi Kivity
2009-05-13 12:55 ` Alex Williamson
2009-05-13 13:00 ` Avi Kivity
2009-05-13 13:11 ` Alex Williamson
2009-05-13 13:55 ` Michael S. Tsirkin
2009-05-13 14:15 ` Alex Williamson
2009-05-13 14:30 ` Michael S. Tsirkin
2009-05-13 14:33 ` Alex Williamson
2009-05-13 23:07 ` Alex Williamson
2009-05-17 20:47 ` Avi Kivity
2009-05-18 11:12 ` Michael S. Tsirkin
2009-05-18 11:36 ` Avi Kivity
2009-05-18 12:19 ` Michael S. Tsirkin
2009-05-18 12:33 ` Avi Kivity
2009-05-18 13:45 ` Michael S. Tsirkin
2009-05-18 13:55 ` Avi Kivity
2009-05-18 14:40 ` Michael S. Tsirkin
2009-05-18 14:46 ` Avi Kivity
2009-05-18 15:01 ` Michael S. Tsirkin
2009-05-18 15:08 ` Avi Kivity
2009-05-13 14:32 ` Michael S. Tsirkin
2009-05-13 15:13 ` [PATCH v5] " Alex Williamson
2009-05-13 16:05 ` Michael S. Tsirkin
2009-05-13 17:13 ` Alex Williamson
2009-05-17 20:51 ` Avi Kivity
2009-05-13 17:28 ` [PATCH v6] " Alex Williamson
2009-05-13 18:46 ` Michael S. Tsirkin
2009-05-17 20:54 ` Avi Kivity
2009-05-18 22:32 ` Alex Williamson
2009-05-19 8:01 ` Avi Kivity
2009-05-19 20:48 ` [PATCH v7] " Alex Williamson
2009-05-20 11:55 ` Avi Kivity
2009-05-13 7:03 ` [PATCH v3] " Michael S. Tsirkin
2009-05-13 12:15 ` Alex Williamson
2009-05-13 7:04 ` Michael S. Tsirkin
2009-05-13 12:19 ` Alex Williamson
2009-05-13 14:25 ` Michael S. Tsirkin
2009-05-17 20:49 ` Avi Kivity [this message]
2009-05-11 12:00 ` [PATCH] " Yang, Sheng
2009-05-12 18:45 ` Alex Williamson
2009-05-12 19:06 ` Alex Williamson
2009-05-12 19:10 ` Michael S. Tsirkin
2009-05-12 19:23 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A10785B.8090906@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).