From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs Date: Sun, 17 May 2009 23:49:31 +0300 Message-ID: <4A10785B.8090906@redhat.com> References: <20090508222925.5119.94814.stgit@dl380g6-3.ned.telco.ned.telco> <20090512220142.5663.72948.stgit@dl380g6-3.ned.telco.ned.telco> <20090513070451.GB31139@redhat.com> <1242217175.4786.50.camel@2710p.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, sheng.yang@intel.com To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33872 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbZEQUte (ORCPT ); Sun, 17 May 2009 16:49:34 -0400 In-Reply-To: <1242217175.4786.50.camel@2710p.home> Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote: > >> On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote: >> >>> @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks, >>> int fd; >>> kvm_context_t kvm; >>> int r; >>> +#ifdef KVM_CAP_IRQ_ROUTING >>> >> Let's kill all these ifdefs. Or at least, let's not add them. >> > > AFAICT, they're still used both for builds against older kernels and > architectures that don't support it. Hollis just added the one around > kvm_get_irq_route_gsi() 10 days ago to fix ppc build. Has it since been > deprecated? Thanks, > They are somewhat documentary. They used to be needed since we supported building against any kernel header, but aren't strictly needed now. Let's keep them until we have Documentation/kvm/extensions.txt. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.