From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v5] kvm: Use a bitmap for tracking used GSIs
Date: Sun, 17 May 2009 23:51:21 +0300
Message-ID: <4A1078C9.9040107@redhat.com>
References: <20090513043835.6696.27384.stgit@dl380g6-3.ned.telco.ned.telco> <20090513150815.8221.49221.stgit@dl380g6-3.ned.telco.ned.telco> <20090513160519.GA1738@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alex Williamson <alex.williamson@hp.com>, kvm@vger.kernel.org,
	sheng.yang@intel.com
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:33898 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752554AbZEQUvZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 17 May 2009 16:51:25 -0400
In-Reply-To: <20090513160519.GA1738@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Michael S. Tsirkin wrote:
>
>> +#ifdef KVM_IOAPIC_NUM_PINS
>>     
>
> I think we should just export
> #define KVM_IOAPIC_NUM_PINS 0
> for ppc in kernel headers (or in libkvm),
> and get rid of this ifdef completely.
>
> Avi, agree?
>
>   

ppc doesn't have an ioapic, so it shouldn't have this define.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.