Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)

[Avi Kivity <avi@redhat.com>]

Mark McLoughlin wrote:
> Currently we only include $(KERNELDIR)/include in CFLAGS,
> but we also have $(KERNELDIR)/arch/$(arch)/include or else
> we'll get mis-matched headers.
>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
> ---
>  kvm/user/config-i386.mak       |    1 -
>  kvm/user/config-ia64.mak       |    1 +
>  kvm/user/config-powerpc.mak    |    1 +
>  kvm/user/config-x86-common.mak |    2 ++
>  kvm/user/config-x86_64.mak     |    1 -
>  5 files changed, 4 insertions(+), 2 deletions(-)
>
>  
> diff --git a/kvm/user/config-ia64.mak b/kvm/user/config-ia64.mak
> index c4c639e..e8803a0 100644
> --- a/kvm/user/config-ia64.mak
> +++ b/kvm/user/config-ia64.mak
> @@ -2,6 +2,7 @@ bits = 64
>  CFLAGS += -m64
>  CFLAGS += -D__ia64__
>  CFLAGS += -I $(KERNELDIR)/include
> +CFLAGS += -I $(KERNELDIR)/arch/ia64/include
> (TEST_DIR)/stringio.flat \
>   

Can we have arch/$(ARCH)/include in some central place instead?  I can't 
bear the thought of touching this again when we merge ARM.

btw, I'd like to see the kvm/user/test stuff ported to load with qemu 
-kernel instead of the custom bootstrap.  We lose the simplicity of 
kvmctl, but we don't really need it now (kvmctl predates qemu-kvm; it 
was how we ran virtual machines until we noticed we didn't have a device 
model).

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.