From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR) Date: Mon, 18 May 2009 01:18:01 +0300 Message-ID: <4A108D19.2060907@redhat.com> References: <1242203541-12959-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43842 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983AbZEQWR4 (ORCPT ); Sun, 17 May 2009 18:17:56 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4HMHw72010051 for ; Sun, 17 May 2009 18:17:58 -0400 In-Reply-To: <1242203541-12959-1-git-send-email-markmc@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Mark McLoughlin wrote: > Currently we only include $(KERNELDIR)/include in CFLAGS, > but we also have $(KERNELDIR)/arch/$(arch)/include or else > we'll get mis-matched headers. > > Signed-off-by: Mark McLoughlin > --- > kvm/user/config-i386.mak | 1 - > kvm/user/config-ia64.mak | 1 + > kvm/user/config-powerpc.mak | 1 + > kvm/user/config-x86-common.mak | 2 ++ > kvm/user/config-x86_64.mak | 1 - > 5 files changed, 4 insertions(+), 2 deletions(-) > > > diff --git a/kvm/user/config-ia64.mak b/kvm/user/config-ia64.mak > index c4c639e..e8803a0 100644 > --- a/kvm/user/config-ia64.mak > +++ b/kvm/user/config-ia64.mak > @@ -2,6 +2,7 @@ bits = 64 > CFLAGS += -m64 > CFLAGS += -D__ia64__ > CFLAGS += -I $(KERNELDIR)/include > +CFLAGS += -I $(KERNELDIR)/arch/ia64/include > (TEST_DIR)/stringio.flat \ > Can we have arch/$(ARCH)/include in some central place instead? I can't bear the thought of touching this again when we merge ARM. btw, I'd like to see the kvm/user/test stuff ported to load with qemu -kernel instead of the custom bootstrap. We lose the simplicity of kvmctl, but we don't really need it now (kvmctl predates qemu-kvm; it was how we ran virtual machines until we noticed we didn't have a device model). -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.