From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 12/17] Increment virtio-net savevm version to avoid conflict with upstream QEMU. Date: Mon, 18 May 2009 02:41:53 +0300 Message-ID: <4A10A0C1.5080508@redhat.com> References: <1242574999-20887-1-git-send-email-aliguori@us.ibm.com> <1242574999-20887-14-git-send-email-aliguori@us.ibm.com> <4A1043B0.5060308@redhat.com> <4A109ED2.7030208@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, Glauber Costa To: Anthony Liguori Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38791 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755208AbZEQXmC (ORCPT ); Sun, 17 May 2009 19:42:02 -0400 In-Reply-To: <4A109ED2.7030208@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >>> When TAP_VNET_HDR eventually merges into upstream QEMU, it cannot >>> change the >>> format of the version 6 savevm data. This means that we're going to >>> have to >>> bump the version up to 7. I'm happy to reserve version 7 as having >>> TAP_VNET_HDR >>> support to allow time to include this support in upstream QEMU. >>> >>> For those shipping products based on KVM though, it's important that >>> we do not >>> conflict with upstream QEMU versioning or else it's going to result >>> in breakage >>> of backwards compatibility. >>> >>> Signed-off-by: Anthony Liguori >>> Signed-off-by: Avi Kivity >>> Signed-off-by: Anthony Liguori >>> >>> >> >> Duplicate signoff. > > Do you care enough for me to resubmit? > Not at all. Just being annoying :) -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.