From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] cleanup arch/x86/kvm/Makefile Date: Mon, 18 May 2009 17:05:58 +0300 Message-ID: <4A116B46.3040303@redhat.com> References: <20090518121614.GA698@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44567 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbZEROGI (ORCPT ); Mon, 18 May 2009 10:06:08 -0400 In-Reply-To: <20090518121614.GA698@infradead.org> Sender: kvm-owner@vger.kernel.org List-ID: Christoph Hellwig wrote: > Use proper foo-y style list additions to cleanup all the conditionals, > move module selection after compound object selection and remove the > superflous comment. > > I think you're patching the wrong tree. > -kvm-objs := $(common-objs) x86.o mmu.o x86_emulate.o i8259.o irq.o lapic.o \ > - i8254.o > I have a timer.o here, for example. -- error compiling committee.c: too many arguments to function