From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/17] Stop/start cpus before/after devices Date: Mon, 18 May 2009 17:55:15 +0300 Message-ID: <4A1176D3.1050908@redhat.com> References: <1242574999-20887-1-git-send-email-aliguori@us.ibm.com> <1242574999-20887-6-git-send-email-aliguori@us.ibm.com> <4A104287.6080000@redhat.com> <20090518135843.GB3168@amt.cnet> <4A117017.400@us.ibm.com> <20090518144729.GD3168@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, Glauber Costa , Yaniv Kamay To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:33693 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbZEROzS (ORCPT ); Mon, 18 May 2009 10:55:18 -0400 In-Reply-To: <20090518144729.GD3168@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Mon, May 18, 2009 at 09:26:31AM -0500, Anthony Liguori wrote: > >> Marcelo Tosatti wrote: >> >>> On Sun, May 17, 2009 at 07:59:51PM +0300, Avi Kivity wrote: >>> >>> >>>> Anthony Liguori wrote: >>>> >>>> >>>>> From: Yaniv Kamay >>>>> >>>>> Stop cpus before devices when stopping the VM, start cpus after devices >>>>> when starting VM. Otherwise a vcpu could access a stopped device. >>>>> >>>>> >>>>> >>>> IIRC we decided this was unnecessary since everything is under >>>> qemu_mutex. However we might want to be on the safe side here and be >>>> similar to master. >>>> >>>> >>> Yes, it is not necessary. Since upstream is already on the safe side >>> (and the plan is to merge with it), IMO better leave this patch out. >>> >>> >> Maybe it ought to be reverted from master then? >> > > Nope, its likelt to be useful in the future. > If we change the locking, we'll likely need to change this. In any case I don't like start/stop; I prefer explicit locking. -- error compiling committee.c: too many arguments to function