From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v6] kvm: Use a bitmap for tracking used GSIs Date: Tue, 19 May 2009 11:01:46 +0300 Message-ID: <4A12676A.3090508@redhat.com> References: <20090513150815.8221.49221.stgit@dl380g6-3.ned.telco.ned.telco> <20090513172350.8722.70990.stgit@dl380g6-3.ned.telco.ned.telco> <4A10798E.4030301@redhat.com> <1242685943.4700.102.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, sheng.yang@intel.com, mst@redhat.com To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58943 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbZESIBt (ORCPT ); Tue, 19 May 2009 04:01:49 -0400 In-Reply-To: <1242685943.4700.102.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > Perhaps we should update the bitmap on entry points that everyone uses > so we don't have to worry about preallocating. We could set the bitmap > in kvm_add_routing_entry() and clear it in kvm_del_routing_entry(). > This would mean that kvm_del_routing_entry() implicitly gives up a GSI > obtained via kvm_get_irq_route_gsi(), which seems to be the assumption > already. > > Much better. > That would eliminate any need for proliferating KVM_CAP_IRQ_ROUTING > ifdefs or doing anything based on KVM_IOAPIC_NUM_PINS, but should I keep > the KVM_CAP_IRQ_ROUTING around the new code for documentation purposes Only around code which directly uses the routing facilities (i.e. only in the libkvm wrappers). Code in qemu should only do runtime detection. I really should write Documentation/kvm/extensions.txt. And ioctls.txt, and intro.txt... -- error compiling committee.c: too many arguments to function