From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 3/4] KVM: introduce irq_lock, use it protect ioapic Date: Wed, 20 May 2009 17:29:46 +0300 Message-ID: <4A1413DA.1070505@redhat.com> References: <20090518165601.747763120@localhost.localdomain> <20090518170855.484310662@localhost.localdomain> <4A13F377.3030500@redhat.com> <20090520141134.GB3370@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:45461 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753713AbZETO3q (ORCPT ); Wed, 20 May 2009 10:29:46 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4KETm1p001556 for ; Wed, 20 May 2009 10:29:48 -0400 In-Reply-To: <20090520141134.GB3370@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Wed, May 20, 2009 at 03:11:35PM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> Signed-off-by: Marcelo Tosatti >>> >>> Index: kvm/include/linux/kvm_host.h >>> =================================================================== >>> --- kvm.orig/include/linux/kvm_host.h >>> +++ kvm/include/linux/kvm_host.h >>> @@ -123,7 +123,6 @@ struct kvm_kernel_irq_routing_entry { >>> }; >>> struct kvm { >>> - struct mutex lock; /* protects the vcpus array and APIC accesses */ >>> >>> >> Why move? >> > > To have it close to the data it protects, for readability. Need to > pahole and organize it at some point. > > Ok. -- error compiling committee.c: too many arguments to function