From mboxrd@z Thu Jan  1 00:00:00 1970
From: Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API
Date: Wed, 20 May 2009 18:48:02 -0400
Message-ID: <4A1488A2.30706@redhat.com>
References: <20090520205758.25003.44632.stgit@localhost.localdomain>	 <20090520205805.25003.71314.stgit@localhost.localdomain> <40e92d5b0905201501i1548621xe1ee63aa88129a0@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 8bit
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,         lkml <linux-kernel@vger.kernel.org>,         systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>,         DLE <dle-develop@lists.sourceforge.net>,         Jim Keniston <jkenisto@us.ibm.com>, "H. Peter Anvin" <hpa@zytor.com>,         Ananth N Mavinakayanahalli <ananth@in.ibm.com>,         Frederic Weisbecker <fweisbec@gmail.com>,         Andi Kleen <ak@linux.intel.com>,         Vegard Nossum <vegard.nossum@gmail.com>, Avi Kivity <avi@redhat.com>
To: =?ISO-8859-2?Q?Przemys=B3aw_Pawe=B3czyk?= <przemyslaw@pawelczyk.it>
Return-path: <systemtap-return-12408-gls-systemtap=m.gmane.org@sourceware.org>
In-Reply-To: <40e92d5b0905201501i1548621xe1ee63aa88129a0@mail.gmail.com>
List-Unsubscribe: <mailto:systemtap-unsubscribe-gls-systemtap=m.gmane.org@sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
List-Id: kvm.vger.kernel.org

Przemysław Pawełczyk wrote:
> On Wed, May 20, 2009 at 22:58, Masami Hiramatsu <mhiramat@redhat.com> wrote:
> 
>> Changes from v5:
> 
>> - Use /usr/bin/env to find awk
> 
> This is fine, but not in the below case.
> 
>> --- /dev/null
>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
>> @@ -0,0 +1,314 @@
>> +#!/usr/bin/env awk -f
> 
> Depending on multi-argument shebang is IMO bad. In shebang generally
> (but not in all systems) everything after interpreter part is treated
> as the first argument. Therefore executing your gen-insn-attr-x86.awk
> is equivalent to:
> 
> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
> 
> which is obviously wrong.

Oops, right. Anyway, there is no reason that we make it
executable because it's always called from Makefile.
So, I think just removing that line is better way.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com