[PATCH] qemu-kvm: Drop obsolete CONFIG_GDBSTUB

[PATCH] qemu-kvm: Drop obsolete CONFIG_GDBSTUB

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

This fixes the recently reported gdbstub regression of qemu-kvm.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

 qemu-kvm.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/qemu-kvm.c b/qemu-kvm.c
index 98c7cd7..bc3d7db 100644
--- a/qemu-kvm.c
+++ b/qemu-kvm.c
@@ -606,13 +606,11 @@ int kvm_main_loop(void)
             qemu_system_powerdown();
         else if (qemu_reset_requested())
 	    qemu_kvm_system_reset();
-#ifdef CONFIG_GDBSTUB
 	else if (kvm_debug_cpu_requested) {
 	    gdb_set_stop_cpu(kvm_debug_cpu_requested);
 	    vm_stop(EXCP_DEBUG);
 	    kvm_debug_cpu_requested = NULL;
 	}
-#endif
     }
 
     pause_all_threads();


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

Re: [PATCH] qemu-kvm: Drop obsolete CONFIG_GDBSTUB

[Avi Kivity]

Jan Kiszka wrote:
> This fixes the recently reported gdbstub regression of qemu-kvm.
>
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function

Re: [PATCH] qemu-kvm: Drop obsolete CONFIG_GDBSTUB

[Aneesh Kumar K.V]

On Thu, May 21, 2009 at 09:51:11AM +0200, Jan Kiszka wrote:
> This fixes the recently reported gdbstub regression of qemu-kvm.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
>  qemu-kvm.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-kvm.c b/qemu-kvm.c
> index 98c7cd7..bc3d7db 100644
> --- a/qemu-kvm.c
> +++ b/qemu-kvm.c
> @@ -606,13 +606,11 @@ int kvm_main_loop(void)
>              qemu_system_powerdown();
>          else if (qemu_reset_requested())
>  	    qemu_kvm_system_reset();
> -#ifdef CONFIG_GDBSTUB
>  	else if (kvm_debug_cpu_requested) {
>  	    gdb_set_stop_cpu(kvm_debug_cpu_requested);
>  	    vm_stop(EXCP_DEBUG);
>  	    kvm_debug_cpu_requested = NULL;
>  	}
> -#endif
>      }
>  
>      pause_all_threads();
> 


Applied this patch to qemu-kvm tree and I get the error
" Remote 'g' packet reply is too long". Is there any other pathches i
should try ?

-aneesh

Re: [PATCH] qemu-kvm: Drop obsolete CONFIG_GDBSTUB

[Aneesh Kumar K.V]

On Thu, May 21, 2009 at 04:27:38PM +0530, Aneesh Kumar K.V wrote:
> On Thu, May 21, 2009 at 09:51:11AM +0200, Jan Kiszka wrote:
> > This fixes the recently reported gdbstub regression of qemu-kvm.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> >  qemu-kvm.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/qemu-kvm.c b/qemu-kvm.c
> > index 98c7cd7..bc3d7db 100644
> > --- a/qemu-kvm.c
> > +++ b/qemu-kvm.c
> > @@ -606,13 +606,11 @@ int kvm_main_loop(void)
> >              qemu_system_powerdown();
> >          else if (qemu_reset_requested())
> >  	    qemu_kvm_system_reset();
> > -#ifdef CONFIG_GDBSTUB
> >  	else if (kvm_debug_cpu_requested) {
> >  	    gdb_set_stop_cpu(kvm_debug_cpu_requested);
> >  	    vm_stop(EXCP_DEBUG);
> >  	    kvm_debug_cpu_requested = NULL;
> >  	}
> > -#endif
> >      }
> >  
> >      pause_all_threads();
> > 
> 
> 
> Applied this patch to qemu-kvm tree and I get the error
> " Remote 'g' packet reply is too long". Is there any other pathches i
> should try ?
> 

Works fine with the below patches

http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=159c7d73428c7df3167babf8253d618aea253338
http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=c84899b311ac882c4f73299ad90b88ed3302b813
http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=125f74afaf973ff4faf6b4a8a4c8262df373fe49
http://git.kiszka.org/?p=kvm-userspace.git;a=commit;h=9d5bc0241268ceea7975ae9e4562fe21484afb68

-aneesh