Re: [PATCH v2] kvm: fix irqfd build failure discovered in linux-next

Gregory Haskins
2009-05-21T14:04:24Z

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Avi Kivity wrote:
> Gregory Haskins wrote:
>> Stephen Rothwell noted a build failure in arch != x86 in last nights
>> linux-next tree, as noted here:
>>
>> http://lkml.org/lkml/2009/5/21/32
>>
>> This patch corrects the build issue by requiring explicit support for
>> IRQFD to be defined, and only defining it on x86 (the only arch fully
>> supported). The code itself isnt architecture dependent, but we need
>> to add a new file to each makefile, advertise the capability, and
>> of course, test that it works for each supported arch. We will submit
>> patches against each relevant arch at a later time to enable support
>> there as well.
>>
>>
>> +config HAVE_KVM_EVENTFD
>> + bool
>> + default y
>> +
>>
>
> The build system will complain if it sees a symbol used but not
> defined; so you have to define it for all four archs. So I went ahead
> and did virt/kvm/Kconfig and adapted your patch to use it.
>
>

Cool, thanks!

-Greg

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 266 bytes --]